gh-101517: fix line number propagation in code generated for except*#103550
Merged
iritkatriel merged 5 commits intopython:mainfrom Apr 24, 2023
Merged
gh-101517: fix line number propagation in code generated for except*#103550iritkatriel merged 5 commits intopython:mainfrom
iritkatriel merged 5 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some virtual instructions with no line number because the whole block is virtual and it has two predecessors.
This PR changes the control flow graph a little to avoid that.
We need to think about how to make the compiler do this automatically, but for now this fixes the bug that was reported.
ZeroDivisionError+ other exception. #101517